用于连接的Excel VBA UDF正在给出错误消息

我试图在Excel中编写一个用户定义的函数（UDF），将采取一定范围的单元格中的值，并以某种方式连接它们。 具体来说，我想连接它们的方式，结果string可以被粘贴到一个SQL“in”函数 – 即如果我有一个范围在Excel中包含：

apples oranges pears 

我想要UDF导致'apples', 'oranges', 'pears'

（即最后一个值后没有逗号）。

这是我的代码 – 它在VBA窗口中编译好，但是当我在工作表中使用它时，我只是得到错误。 任何想法都非常感谢 – 我在写VBA时有点新手。 并对这个模糊的问题表示歉意。 我只是不知所措，看看是哪一点造成了麻烦。

 Function ConcatenateforSQL(ConcatenateRange As Range) As Variant Dim i As Long Dim strResult1 As String Dim strResult2 As String Dim Separator1 As String Dim Separator2 As String Separator1 = "'" 'hopefully the quotes act as escape characters Separator2 = "'," On Error GoTo ErrHandler For i = 1 To CriteriaRange.Count - 1 'all but the last one strResult1 = strResult1 & Separator1 & ConcatenateRange.Cells(i).Value & Separator2 Next i 'next, sort out the last example in the string For i = CriteriaRange.Count - 0 To CriteriaRange.Count + 0 strResult2 = strResult1 & Separator1 & ConcatenateRange.Cells(i).Value & Separator1 Next i ConcatenateforSQL = strResult2 Exit Function ErrHandler: ConcatenateforSQL = CVErr(xlErrValue) End Function 

Answer 1

我更喜欢JOIN数组方法。

 Option Explicit Function ConcatenateforSQL(ConcatenateRange As Range) As Variant On Error GoTo ErrHandler Dim r As Long, c As Long Dim vVAL As Variant, vVALS As Variant ReDim vVAL(1 To 1) vVALS = ConcatenateRange.Value2 For r = LBound(vVALS, 1) To UBound(vVALS, 1) For c = LBound(vVALS, 2) To UBound(vVALS, 2) 'Debug.Print vVALS(r, c) ReDim Preserve vVAL(1 To (r * c)) vVAL(r * c) = vVALS(r, c) Next c Next r ConcatenateforSQL = Chr(39) & Join(vVAL, "','") & Chr(39) Exit Function ErrHandler: ConcatenateforSQL = CVErr(xlErrValue) End Function 

Answer 2

这适用于我（随时添加您的错误陷阱等）：

 Function ConcatenateforSQL(ConcatenateRange As Range) As Variant Dim csql As String csql = "" For Each cl In ConcatenateRange If Len(cl) > 0 Then If csql <> "" Then csql = csql & "," csql = csql & "'" & cl.Value & "'" End If Next ConcatenateforSQL = csql End Function 

Answer 3

一个稍微不同的方法，它允许你指定逗号分隔符（如果你不指定，它将是一个逗号）。 可以为另一个增加一个进一步的论点。

 Function ConcatenateforSQL(ConcatenateRange As Range, Optional sSep As String = ",") As Variant Dim i As Long Dim strResult As String On Error GoTo ErrHandler For i = 1 To ConcatenateRange.Count strResult = strResult & sSep & "'" & ConcatenateRange.Cells(i).Value & "'" Next i ConcatenateforSQL = Mid(strResult, Len(sSep) + 1) Exit Function ErrHandler: ConcatenateforSQL = CVErr(xlErrValue) End Function